New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install xacro using console_scripts entrypoint #304
install xacro using console_scripts entrypoint #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks more promising!
I was thinking about symlinking from lib/xacro
to bin
instead of installing the file a second time.
Symlinks are not supported in Windows.
... to ensure EXEC permissions
Looks like the new feature was only released into |
Ah i didnt notice this because I use rolling. Does this change need to wait until backports to non-eol distros are released then? |
Yes, I cannot release in this state. I also suggested some changes: ament/ament_cmake#328 (comment) |
I think the backport has been released. Could this PR be merged now? |
I think this is also blocked by ament/ament_cmake#372. Will double check... |
Closing and reopening to trigger CI. |
This changes xacro to be install using a console_script entrypoint, which now fixes running
xacro
andros2 run xacro xacro
in windows. linux functionality should be unchanged.closes #302
supersedes #303