Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the error handler replace to allow non-utf8 to be decoded #381

Merged
merged 4 commits into from
Mar 23, 2023
Merged

use the error handler replace to allow non-utf8 to be decoded #381

merged 4 commits into from
Mar 23, 2023

Commits on Mar 14, 2023

  1. use the error handler surrogateescape to allow non-utf8 to be decoded 

    Fixes ament#379

Signed-off-by: Alaa <ejalaa12@gmail.com>
    @ejalaa12 @clalancette
    ejalaa12 authored and clalancette committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6bc7e69 View commit details
    Browse the repository at this point in the history

  2. use replace as fallback when all encodings failed 

    Signed-off-by: Alaa <ejalaa12@gmail.com>
    @ejalaa12 @clalancette
    ejalaa12 authored and clalancette committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    628b86e View commit details
    Browse the repository at this point in the history

  3. Add in a test for invalid characters in ament_cmake_test. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f823d51 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Update ament_cmake_pytest/test/test_pyunicode.py 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>

Co-authored-by: Michael Carroll <carroll.michael@gmail.com>
    @clalancette @mjcarroll
    clalancette and mjcarroll committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f9e3d69 View commit details
    Browse the repository at this point in the history