ament_python_install_package: exclude libraries from install #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hen rosidl_python is run to generate messages, the lib<msgname>__rosidl_generator_py.so (in case of linux) is installed into PYTHON_INSTALL_DIR and lib. This is a regression from foxy to humble. In the past, only .py files were copied, now we copy over the complete directory, which happens to also have the above library in it. Since I do not know better, I exclude libraries from being copied. Signed-off-by: Matthias Schoepfer <m.schoepfer@rethinkrobotics.com>
|
Any opinion? Any Reaction? |
ghost
mentioned this pull request
|
Bump...Any updates? Nearly a year since this was submitted and it is still an active issue. |
|
Maybe @clalancette can comment on this. For me, this is not that much of a blocker, since this patch is sadly just one of many that we carry around. |
|
I just merged in ros2/rosidl_python#195, which is the better fix for this issue. With that, I'm going to close this PR out, since it shouldn't be necessary anymore. |
|
I agree, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hen rosidl_python is run to generate messages, the lib__rosidl_generator_py.so (in case of linux) is installed into PYTHON_INSTALL_DIR and lib. This is a regression from foxy to humble. In the past, only .py files were copied, now we copy over the complete directory, which happens to also have the above library in it.
Since I do not know better, I exclude libraries from being copied.
See: ros2/rosidl_python#186
Signed-off-by: Matthias Schoepfer m.schoepfer@rethinkrobotics.com