Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configuration to 0.67 #103

Merged
merged 2 commits into from
Jul 11, 2018
Merged

update configuration to 0.67 #103

merged 2 commits into from
Jul 11, 2018

Conversation

mikaelarguedas
Copy link
Contributor

Connects to ament/uncrustify#24

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jul 9, 2018
@@ -370,6 +383,9 @@ sp_square_fparen = remove # ignore/add/remove/force
# Add or remove space between ')' and '{' of function.
sp_fparen_brace = force # ignore/add/remove/force

# Add or remove space between ')' and '{' of function call in object initialization. Overrides sp_fparen_brace.
sp_fparen_brace_initializer = ignore # ignore/add/remove/force
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this overrides sp_fparen_brace should it be the same value - force?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done in 43a0307

@mikaelarguedas mikaelarguedas self-assigned this Jul 9, 2018
@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 9, 2018
@mikaelarguedas mikaelarguedas merged commit d449f43 into master Jul 11, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 11, 2018
@mikaelarguedas mikaelarguedas deleted the uncrustify_0.67 branch July 11, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants