Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encoding of copyright result file #139

Merged
merged 1 commit into from
May 3, 2019
Merged

fix encoding of copyright result file #139

merged 1 commit into from
May 3, 2019

Conversation

dirk-thomas
Copy link
Contributor

Fixes encoding of result file so that Jenkins can parse it.

Before: https://ci.ros2.org/view/nightly/job/nightly_win_deb/1239/console#console-section-0

WARNING Skipping 'build\sensor_msgs\test_results\sensor_msgs\copyright.xunit.xml': not well-formed (invalid token): line 69, column 42

After: Build Status

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels May 3, 2019
@dirk-thomas dirk-thomas self-assigned this May 3, 2019
nuclearsandwich
nuclearsandwich approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with DCO fix.

@dirk-thomas
fix encoding of copyright result file
29c9cc2 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas merged commit 462f920 into master May 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-encoding branch May 3, 2019 15:58
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label May 3, 2019
@dirk-thomas dirk-thomas mentioned this pull request May 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @nuclearsandwich