Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding copyright headers, which are failing this module #3

Merged
merged 1 commit into from
Mar 7, 2015
Merged

adding copyright headers, which are failing this module #3

merged 1 commit into from
Mar 7, 2015

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Mar 7, 2015

No description provided.

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Mar 7, 2015
@tfoote
Copy link
Member Author

tfoote commented Mar 7, 2015

This should fix 2 failures on the new CI job: http://54.183.26.131:8080/job/ros2_batch_ci/ from ros2/ros2#2

dirk-thomas
dirk-thomas reviewed Mar 7, 2015
View reviewed changes
ament_copyright/ament_copyright/__init__.py
@@ -1,3 +1,17 @@
# Copyright 2015 Open Source Robotics Foundation, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2014

@dirk-thomas
Copy link
Contributor

Since a lot of files will require the same patch I would recommend to extend ament_copyright instead and add an option --update which does the modification automatically and in a consistent way.

@esteve
Copy link
Contributor

esteve commented Mar 7, 2015

+1

@tfoote
Copy link
Member Author

tfoote commented Mar 7, 2015

updated year

@tfoote tfoote self-assigned this Mar 7, 2015
@wjwwood wjwwood mentioned this pull request Mar 7, 2015
Closed
@tfoote tfoote mentioned this pull request Mar 7, 2015
Closed
@tfoote
Copy link
Member Author

tfoote commented Mar 7, 2015

I ticketed the --update option in #4 I just want to try merging this to change the CI results.

dirk-thomas
dirk-thomas reviewed Mar 7, 2015
View reviewed changes
ament_copyright/bin/ament_copyright
@@ -1,4 +1,17 @@
#!/usr/bin/env python3
# Copyright 2014 Open Source Robotics Foundation, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a newline before this? Otherwise the shebang line kind of "disappears".

@tfoote
Copy link
Member Author

tfoote commented Mar 7, 2015

Separated the shebang line

@wjwwood
Copy link
Contributor

wjwwood commented Mar 7, 2015

+1 to the empty line between the shebang and the copyright.

@tfoote tfoote added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 7, 2015
tfoote added a commit that referenced this pull request Mar 7, 2015
@tfoote
Merge pull request #3 from ament/copyright_headers
34df8ec 
adding copyright headers, which are failing this module
@tfoote tfoote merged commit 34df8ec into master Mar 7, 2015
@tfoote tfoote removed the in review Waiting for review (Kanban column) label Mar 7, 2015
@tfoote tfoote deleted the copyright_headers branch March 7, 2015 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tfoote tfoote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tfoote @dirk-thomas @esteve @wjwwood