Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_lint_cmake: default linelength in argumentparser for consistency #306

Conversation

emersonknapp
Copy link
Contributor

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp
Copy link
Contributor Author

@audrow review please :)

@emersonknapp emersonknapp force-pushed the emersonknapp/cmake-default-linelength-in-one-place branch from 780125f to 8e06f25 Compare March 12, 2021 18:38
Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@audrow audrow self-assigned this Mar 12, 2021
@audrow
Copy link
Contributor

audrow commented Mar 12, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow
Copy link
Contributor

audrow commented Mar 15, 2021

The CI failures appear to be in the nightly as well: https://ci.ros2.org/view/nightly/job/nightly_linux_release/1852/.

An issue was made here: ros2/demos#490.

@audrow audrow merged commit 017f48b into ament:master Mar 15, 2021
@audrow
Copy link
Contributor

audrow commented Mar 15, 2021

Thanks for the PR, @emersonknapp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake linter default line length differs depending on invocation
2 participants