Change linelength from hardcoded value to argument #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-prody
requested review from
thomas-moulard and
zmichaels11
and removed request for
a team
david-prody
force-pushed
the
arg
branch
3 times, most recently
from
b5d084d
to
024aeb0
Compare
Some linters do not support the parameter. setting it up as an input argument allows individual tests to decide if they needed and what the appropriate value is. Signed-off-by: David Prody <prodyd@amazon.com>
|
Maybe we should skip this in favor of #253 - given that the upstream problem is now handled in ament/ament_lint#306 ? |
Since the upstream problem has been fixed and the revert has already been commited we can skip this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some linters do not support the --linelength parameter. changing to argument so that each test can specify the value if needed