update clang format #55
Conversation
| @@ -44,7 +72,7 @@ def main(argv=sys.argv[1:]): | |||
| print('No files found', file=sys.stderr) | |||
| return 1 | |||
|
|
|||
| bin_names = ['clang-format-3.5', 'clang-format-3.4', 'clang-format-3.3'] | |||
| bin_names = ['clang-format-3.8', 'clang-format-3.7', 'clang-format-3.6', 'clang-format-3.5', 'clang-format-3.4', 'clang-format-3.3'] | |||
There was a problem hiding this comment.
On OS X the bin name is just clang-format.
There was a problem hiding this comment.
Added in abb625f
|
Seems reasonable to me, though I didn't check to see if it matched our style. The other thing I noticed when trying to revive this before is that the setting may not be flexible enough to meet our current style. I don't remember off hand which thing was giving me trouble, but there were a few things you couldn't seem to change. If the goal is just to get it working but not have it match our current style then +1. |
|
This patch gets it in a working and configurable state. based on that anyone who would like to fiddle with the style options can try to update the config to match our style (or our style updated to match clang-format). |
Split into Python and CMake package as well as use a configuration file to define the style.
Currently the config uses the Google style and is not matching our existing code.