Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang_format line references are incorrect #6

Closed
tfoote opened this issue Mar 9, 2015 · 3 comments
Closed

clang_format line references are incorrect #6

tfoote opened this issue Mar 9, 2015 · 3 comments
Assignees

Comments

@tfoote
Copy link
Member

tfoote commented Mar 9, 2015

This file has 124 lines, but it's citing line 5529.

http://54.183.26.131:8080/job/ros2_batch_ci/lastCompletedBuild/testReport/%28root%29/replacement/__include_rosidl_generator_c_arrays_h_5529/

replacement../include/rosidl_generator_c/arrays.h:5529 (from clang_format)
Failing for the past 1 build (Since Unstable#83 )
Took 0 ms.
Stacktrace

Replace 81 characters with [         \\n    ]
@dirk-thomas
Copy link
Contributor

The index in your output refers to the byte offset in the file.

This has already been improved in 2b77c91 which converts the global offset into a line number and offset-in-line.

@dirk-thomas
Copy link
Contributor

The output of the unit tests already does the conversion but the written xml file does still use global offsets.

@dirk-thomas dirk-thomas reopened this Mar 9, 2015
@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Mar 11, 2015
@dirk-thomas dirk-thomas self-assigned this Mar 11, 2015
@dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants