Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWYU not in sync #68

Closed
Karsten1987 opened this issue Feb 9, 2017 · 2 comments
Closed

IWYU not in sync #68

Karsten1987 opened this issue Feb 9, 2017 · 2 comments

Comments

@Karsten1987
Copy link
Contributor

I recently ran into an issue of the cpplint which was merged upstream but doesn't seem to be merged in our repo.
https://github.com/google/styleguide/pull/158/files

@dirk-thomas
Copy link
Contributor

It looks to me that our version of the file already contains the patch of the referenced PR:

matched = pattern.search(line)
if matched:
# Don't warn about IWYU in non-STL namespaces:
# (We check only the first match per line; good enough.)
prefix = line[:matched.start()]
if prefix.endswith('std::') or not prefix.endswith('::'):
required[header] = (linenum, template)

@Karsten1987
Copy link
Contributor Author

Karsten1987 commented Feb 9, 2017

Must have overlooked that. Sorry for the noise then.
FWIW, the linter will complain every time you use the word 'string' as a variable name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants