Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses xml version 2 for cppcheck output.
Rationale:
cppcheck deprecated usage of version 1 in the last releases, and will completely drop support in v1.81.
We started to see deprecation warnings show on Mac and Windows CIs (
cppcheck: XML format version 1 is deprecated and will be removed in cppcheck 1.81. Use '--xml-version=2'
) e.g. http://ci.ros2.org/view/nightly/job/nightly_osx_debug/373Tested with a few errors for either same or different kind and the generated xunit file is identical as with version 1.
Errors tested: