This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 687 kB ℹ️ View Unchanged
|
JAdshead
force-pushed
the
feat/request-time-metrics
branch
from
June 16, 2023 22:58
db9ea62
to
6a6c6fe
Compare
JAdshead
commented
Jun 19, 2023
@@ -1578,9 +1578,6 @@ describe('Tests that require Docker setup', () => { | |||
date: [ | |||
expect.any(String), | |||
], | |||
'expect-ct': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect-ct is deprecated - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expect-CT
giulianok
approved these changes
Jun 20, 2023
10xLaCroixDrinker
approved these changes
Jun 21, 2023
dogpatch626
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds metrics for tracking response time.
Includes a fix for
configureRequestLog
which was silently throwing. Required to enable this feature.Motivation and Context
Provide metrics to summarize the total time it takes for the
one-app
server to send response back to client.How Has This Been Tested?
Locally and unit tests
Types of Changes
Checklist:
What is the Impact to Developers Using One App?