This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat(config): new config redirectAllowList #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 689 kB ℹ️ View Unchanged
|
Matthew-Mallimo
force-pushed
the
feat/redirectAllowList
branch
from
67b1214
to
a370be2
Compare
smackfu
reviewed
Jul 11, 2023
bishnubista
reviewed
Jul 12, 2023
dogpatch626
previously approved these changes
Jul 13, 2023
code-forger
reviewed
Jul 13, 2023
code-forger
reviewed
Jul 13, 2023
code-forger
reviewed
Jul 13, 2023
10xLaCroixDrinker
suggested changes
Jul 13, 2023
bishnubista
previously approved these changes
Jul 17, 2023
10xLaCroixDrinker
previously approved these changes
Jul 27, 2023
JAdshead
reviewed
Aug 1, 2023
__tests__/server/plugins/reactHtml/createRequestHtmlFragment.spec.jsx
Outdated
Show resolved
Hide resolved
JAdshead
suggested changes
Aug 1, 2023
Comment on lines
+120
to
+123
| if (!isRedirectUrlAllowed(redirect.url)) { | ||
| renderStaticErrorPage(request, reply); | ||
| throw new Error(`'${redirect.url}' is not an allowed redirect URL`); | ||
| } |
There was a problem hiding this comment.
i think if an error is thrown it should always result in renderStaticErrorPage if not the case thats probably how it should work
There was a problem hiding this comment.
Throwing an error does not render the error page for us, verified this locally.
There was a problem hiding this comment.
after looking into this further, this is the expected pattern.
JAdshead
reviewed
Aug 1, 2023
| module, | ||
| moduleName, | ||
| }) { | ||
| export function setRootModuleConfigurations(module, moduleName) { |
There was a problem hiding this comment.
this change should not be necessary with https://github.com/americanexpress/one-app/pull/984/files#diff-c2c760b479b24ea34c7eae704bba77b771c6ce7b48f7b4e6c8b386140de2ca9b
There was a problem hiding this comment.
But that is a draft PR thats expected to go in after this PR
code-forger
approved these changes
Aug 2, 2023
JAdshead
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new
appConfigoption to configure an allow list for redirects.Motivation and Context
We dont want to redirect anyone to malicious URLs in the case of user-inputed redirects.
How Has This Been Tested?
Unit and locally
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Allows further security enhancements through a customizable allow list.