This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat(ssrServer): added readiness check route #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle Size Report
|
infoxicator
previously approved these changes
Jul 20, 2020
nellyk
previously approved these changes
Jul 20, 2020
JAdshead
reviewed
Jul 21, 2020
src/server/ssrServer.js
Outdated
| @@ -61,6 +61,7 @@ export function createApp({ enablePostToModuleRoutes = false } = {}) { | |||
| app.use(forwardedHeaderParser); | |||
|
|
|||
| app.use('/_/static', express.static(path.join(__dirname, '../../build'), { maxage: '182d' })); | |||
| app.get('/_/ready', (req, res) => res.sendStatus(200)); | |||
There was a problem hiding this comment.
thought we were going to use /_/status
There was a problem hiding this comment.
Since it always returns a 200, this was agreed on for restfulnessstatus seems a bit too specific
Francois-Esquire
previously approved these changes
Jul 23, 2020
10xLaCroixDrinker
dismissed stale reviews from Francois-Esquire, nellyk, and infoxicator
via
0d2ca24
JAdshead
approved these changes
Jul 28, 2020
Francois-Esquire
approved these changes
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new route for detecting the app is ready to take traffic
Motivation and Context
Allows deployment processes to detect the app is ready
How Has This Been Tested?
sent the route traffic locally and unit tests
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Smoother automated deployments