Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(watchLocalModules): fix watcher crashing due to build errors #306

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

JamesSingleton
Copy link
Contributor

@JamesSingleton JamesSingleton commented Sep 16, 2020

This was caused when a module would throw a linting error or something similar
during the building of the module. This was not being caught and therefore was causing
the app to crash.

Description

Fixes an issue where a build failure when doing npm run watch:build in a module would cause the entire app to crash.

Motivation and Context

Improve DX.

How Has This Been Tested?

Locally

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

N/A other than better DX

This was caused when a module would throw a linting error or something similar
during the building of the module. This was not being caught and therefore was causing
the app to crash.
@JamesSingleton JamesSingleton requested review from a team as code owners September 16, 2020 23:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 276.2KB 82.4KB
runtime.js 15KB 5.4KB
vendors.js 117.4KB 36.4KB
app~vendors.js 423.8KB 110.8KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 291.4KB 85.6KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.9KB 47.1KB
legacy/app~vendors.js 438.6KB 113.9KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against d2f8df1

@JamesSingleton JamesSingleton merged commit 9290d92 into master Sep 22, 2020
@JamesSingleton JamesSingleton deleted the bugfix/fix-crash-during-polling branch September 22, 2020 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants