Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(ssrServer): enable urlencoded post data #313

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

sumanramagoni
Copy link
Contributor

@sumanramagoni sumanramagoni commented Sep 23, 2020

post parameters are available in req.body only when request content-type is application/json. There is no way to handle default encoding method.

Description

Feature to enable form post with default encoding method application/x-www-form-urlencoded

Motivation and Context

There is a need for the clients to use form post for sharing information on to the application. This feature is already available in lower version of one-app.

How Has This Been Tested?

Tested it locally by posting parameters, we could verify all of the post parameters in req.body

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

NA

@sumanramagoni sumanramagoni requested review from a team as code owners September 23, 2020 20:58
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2020

CLA assistant check
All committers have signed the CLA.

@sumanramagoni sumanramagoni force-pushed the bugfix/formpost branch 2 times, most recently from e5decd7 to e9707fa Compare September 28, 2020 22:02
@sumanramagoni sumanramagoni reopened this Sep 29, 2020
@nellyk nellyk changed the base branch from master to main September 29, 2020 18:15
Copy link
Contributor

@Francois-Esquire Francois-Esquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small list of requests:

  • Docs need to be added

then its good by me!

Possibly do we want to make this an opt in? users can set to true to use

@Francois-Esquire
Copy link
Contributor

Btw, thank you very much for your contribution 🙏

@sumanramagoni sumanramagoni changed the title fix(ssrServer): enable urlencoded post data feat(ssrServer): enable urlencoded post data Oct 2, 2020
@sumanramagoni
Copy link
Contributor Author

I have a small list of requests:

  • Docs need to be added

then its good by me!

Possibly do we want to make this an opt in? users can set to true to use

I've added documentation under Making-An-Api-Call

@JAdshead JAdshead merged commit 3481dc0 into americanexpress:main Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants