This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle Size Report
|
JAdshead
force-pushed
the
feat/track-intl-server-cache
branch
from
January 12, 2021 20:38
0c09fe2
to
166a4b2
Compare
infoxicator
reviewed
Jan 13, 2021
@JAdshead I think you mentioned before but can you write here how is the size collected overtime and the workaround so we don't have to use the module map poll |
Co-authored-by: Ruben Casas <ruben@infoxication.net>
JAdshead
commented
Jan 13, 2021
|
||
collectDefaultMetrics(); | ||
metricsRegister.registerCollector(cacheSizeCollector); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infoxicator the register ensures that the cacheSizeCollector is called in the same manor default metrics are collected
infoxicator
approved these changes
Jan 13, 2021
Francois-Esquire
approved these changes
Jan 13, 2021
JamesSingleton
approved these changes
Jan 13, 2021
funtimeerrors-zz
pushed a commit
that referenced
this pull request
Jan 26, 2021
This was referenced Feb 3, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Track intl cache size
Motivation and Context
This will allow us to track the changes in lang pack caching overtime
How Has This Been Tested?
locally using the prod-sample and unit tests
Types of Changes
Checklist:
What is the Impact to Developers Using One App?