This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
feat(one-app): removed tenancy or tenant instances #69
Merged
NarmeenNaveedAhmed
merged 21 commits into
master
from
feature/remove-tenancy-or-tenant-instances
Apr 29, 2020
Merged
feat(one-app): removed tenancy or tenant instances #69
NarmeenNaveedAhmed
merged 21 commits into
master
from
feature/remove-tenancy-or-tenant-instances
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle Size Report
|
nellyk
reviewed
Mar 17, 2020
nellyk
reviewed
Mar 17, 2020
JamesSingleton
previously approved these changes
Mar 24, 2020
JAdshead
suggested changes
Mar 24, 2020
prod-sample/sample-modules/frank-lloyd-root/0.0.2/src/components/FrankLloydRoot.jsx
Outdated
Show resolved
Hide resolved
mtomcal
suggested changes
Mar 24, 2020
…github.com/americanexpress/one-app into feature/remove-tenancy-or-tenant-instances
nellyk
approved these changes
Apr 28, 2020
10xLaCroixDrinker
approved these changes
Apr 28, 2020
JAdshead
approved these changes
Apr 28, 2020
mtomcal
approved these changes
Apr 29, 2020
JamesSingleton
deleted the
feature/remove-tenancy-or-tenant-instances
branch
September 7, 2020 16:21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for removing/replacing(where needed) all the instances of tenancy and tenant.
Motivation and Context
This is to ensure consistency in the code base and to keep it generic.
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
The idea is to keep it as generic so specific keywords like tenant or tenancy do not cause any confusion for developers.