Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redux): redux 5 compatible #47

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Feb 1, 2024

Description

Add redux 5 as a compatible peer dependency.
Run tests with redux@5
add test to validate compatibility with redux toolkit.

Motivation and Context

How Has This Been Tested?

Unit tests.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for vitruvius users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using vitruvius?

"redux-immutable": "^4.0.0",
"rimraf": "^5.0.5",
"semantic-release": "^22.0.12"
},
"peerDependencies": {
"immutable": "^3||^4.0.0-rc",
"redux": "^3||^4",
"redux": "^3||^4||^5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"redux": "^3||^4||^5",
"redux": "<=5",

Might make this more maintainable in the future?

@10xLaCroixDrinker 10xLaCroixDrinker merged commit e23b819 into main Feb 1, 2024
3 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/redux-5 branch February 1, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants