Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support back-face culling in SimpleGraphicsPipeline #86

Closed
bonsairobo opened this issue Mar 31, 2019 · 2 comments
Closed

Support back-face culling in SimpleGraphicsPipeline #86

bonsairobo opened this issue Mar 31, 2019 · 2 comments
Labels
diff: easy enhancement New feature or request good first issue Good for newcomers

Comments

@bonsairobo
Copy link

bonsairobo commented Mar 31, 2019

I believe this would only require configuration of the rasterizer field in the GraphicsPipelineDesc passed to create_graphics_pipelines.

https://github.com/omni-viral/rendy/blob/564e7e80824afc124d57c5220e57da20f12f8e8e/graph/src/node/render/group/simple.rs#L291

Edit: Also note that front-face culling is a good technique for avoiding shadow-acne while rendering shadow maps.

@bonsairobo bonsairobo changed the title [Performance] Support back-face culling Support back-face culling Apr 6, 2019
@bonsairobo bonsairobo changed the title Support back-face culling Support back-face culling in SimpleGraphicsPipeline Apr 14, 2019
@bonsairobo
Copy link
Author

I just realized that a custom RenderGroup can specify it's rasterizer.

@zakarumych
Copy link
Member

@bonsairobo yes. In RenderGroup you can create any numbervof pipelines manually.
However adding rasterizer parameter to simple pipeline should be pretty straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff: easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants