This repository has been archived by the owner on Sep 19, 2022. It is now read-only.
Add gold system #31
Merged
Add gold system #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnneKitsune
reviewed
Jan 13, 2021
There was a problem hiding this comment.
I think you should replace the DoubleGold effector by DoubleGoldGain, and create a new stat called GoldGainMultiplier, then use this multiplier stat inside of transfer_gold_system. This way we can have multiple effectors modifying the gold gain multiplier per kill, as well as reducing the amount of code needed by reusing the effector logic.
|
Done! (: |
AnneKitsune
reviewed
Jan 13, 2021
src/systems/game_stats_updater.rs
Outdated
| GameEvent::KillEntity(_) => game_stats.kill_count += 1, | ||
| GameEvent::TransferGold(_, _, gold) => game_stats.earned_gold += gold, |
There was a problem hiding this comment.
This does not take into account gold that was gained from the gold gain multiplier
There was a problem hiding this comment.
oops, would you suggest to do the calculation of the multiplier again or pass the gold amount multiplied already?
There was a problem hiding this comment.
What about:
GameEvent::TransferGold(from, to)
GameEvent::TransferedGold(to, multiplied_quantity)
AnneKitsune
approved these changes
Jan 13, 2021
|
Nice work! <3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a system to transfer gold from an entity that has died to the entity that killed it.