Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Minio ingestion fails with no bucket in connection details #31

Closed
mawandm opened this issue Apr 19, 2024 · 0 comments · Fixed by #55
Closed

[BUG] Minio ingestion fails with no bucket in connection details #31

mawandm opened this issue Apr 19, 2024 · 0 comments · Fixed by #55
Labels
bug Something isn't working

Comments

@mawandm
Copy link
Contributor

mawandm commented Apr 19, 2024

Nesis version

0.0.2

Describe the bug

When no bucket is supplied in the minio connection details, this causes the ingestion process to fail. We should not permit the minio connection details without a bucket.

To reproduce

No response

Expected behavior

No response

Screenshots

No response

Additional context

No response
@mawandm mawandm added the bug Something isn't working label Apr 19, 2024
@mawandm mawandm mentioned this issue Apr 27, 2024
Merged
akizito pushed a commit that referenced this issue Apr 28, 2024
@mawandm @akizito
feat(frontend)(api): add datasource type specific input validation (#55)
1b68f7f 
This PR
1. Enforces validation on each current datasource type in order to ensure that the correct data is inputted into the connection object.
2. Updates documentation to fix invalid inputs for the local run

Closes #54
Closes #31
Closes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(frontend): add datasource type specific input validation ametnes/nesis
1 participant
@mawandm