Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add datasource type specific input validation #55

Merged
merged 7 commits into from
Apr 27, 2024
Merged

feat(frontend): add datasource type specific input validation #55

merged 7 commits into from
Apr 27, 2024

Conversation

mawandm
Copy link
Contributor

@mawandm mawandm commented Apr 26, 2024 •
edited

This PR

  1. nforces validation on each current datasource type in order to ensure that the correct data is inputted into the connection object.
  2. Updates documentation to fix invalid inputs for the local run

Closes #54
Closes #31
Closes #30

@mawandm mawandm marked this pull request as ready for review April 27, 2024 19:51
@mawandm mawandm enabled auto-merge (squash) April 27, 2024 19:52
@mawandm mawandm disabled auto-merge April 27, 2024 20:02
@mawandm mawandm merged commit 360abaf into main Apr 27, 2024
6 checks passed
@mawandm mawandm deleted the 54-add-datasource-type-inputs branch April 27, 2024 20:03
akizito pushed a commit that referenced this pull request Apr 28, 2024
@mawandm @akizito
feat(frontend)(api): add datasource type specific input validation (#55)
1b68f7f 
This PR
1. Enforces validation on each current datasource type in order to ensure that the correct data is inputted into the connection object.
2. Updates documentation to fix invalid inputs for the local run

Closes #54
Closes #31
Closes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mawandm