-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the ConvexHullHelper class #51
Conversation
On |
The CI seems to fail on:
It seems that the symbols
To debug this kind of issues, I would start to check if those symbols are actually defined somewhere by using https://github.com/lucasg/Dependencies , but you can also concentrate for now on the walking planner and solve this fun windows problems later. : ) |
@traversaro, I'm trying to replicate the error on windows (right now I'm installing the superbuild) |
Edit 1: I noticed that **Edit2: ** Compiling qhull from visual studio I noticed that two versions of
@traversaro Do you think this may be the cause of the problem? |
On Windows, shared library are composed by two files: the import library |
e62a3af
to
36623d9
Compare
36623d9
to
02524c6
Compare
This commit Homebrew/homebrew-core@6ca6c77 introduces |
Discussing with @traversaro we realized that enabling the linking of
For the time being, we decided to drop the support for windows for this particular component.
Since the compilation on Windows is an important feature that I do not want to drop, I consider this solution only temporary. On the light of what I just explained. I will remove the |
This follows from #51 (comment)
@S-Dafarra , @MiladShafiee @prashanthr05 @traversaro when you have time you can review the PR 😄 |
This fixes the compilation problem on Windows
46e4cb5
to
8022263
Compare
8022263
to
474f696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
src/Planners/include/BipedalLocomotion/Planners/ConvexHullHelper.h
Outdated
Show resolved
Hide resolved
…ullHelperTest::getB() if the convex hull is not built
5153be5
to
f1bdb21
Compare
This PR introduces the first version of the
ConvexHullHelper
class inside the Planner Component.In order to use the helper, and in general to compile the component, the Qhull library is now required.