Preserve the original terrain in reduced models #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xela-95
force-pushed
the
fix/reduce-model-terrain
branch
from
e94c2ed
to
2f47dad
Compare
diegoferigo
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Great, thanks @xela-95! This attribute was not moved automatically to the new reduced model.
diegoferigo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug occurring when reducing a model with
jaxsim.api.model.reduce, in which the terrain specification was not preserved.馃摎 Documentation preview 馃摎: https://jaxsim--168.org.readthedocs.build//168/