Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prismatic joints transform in math.joint_model.supported_joint_motion #170

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix prismatic joints transform in math.joint_model.supported_joint_motion #170

merged 1 commit into from
Jun 5, 2024

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Jun 5, 2024 •
edited by github-actions bot

The method jaxlie.SE3.from_translation used to calculate the parent-child transform for prismatic joints doesn't actually exists

馃摎 Documentation preview 馃摎: https://jaxsim--170.org.readthedocs.build//170/

@flferretti
Fix jaxlie error in math.joint_model.supported_joint_motion
a260650 
The method `jaxlie.SE3.from_translation` doesn't actually exists
@flferretti flferretti self-assigned this Jun 5, 2024
diegoferigo
diegoferigo approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I think here Copilot tricked me and we don't have checks with models having prismatic joints (not a priority). Thanks!

@flferretti flferretti merged commit 4a7e2e8 into main Jun 5, 2024
30 checks passed
@flferretti flferretti deleted the flferretti-patch-2 branch June 5, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoferigo diegoferigo diegoferigo approved these changes

Assignees

@flferretti flferretti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flferretti @diegoferigo