Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ace/config.h must go away #18

Closed
tehKaiN opened this issue Nov 2, 2017 · 0 comments
Closed

ace/config.h must go away #18

tehKaiN opened this issue Nov 2, 2017 · 0 comments
Labels
enhancement

Comments

@tehKaiN
Copy link
Member

tehKaiN commented Nov 2, 2017 •
edited
Loading

Currently, this file only contains extern consts containing screen size. This approach is unnecessary since ACE really supports only PAL modes atm and values other than 320/256 may yield unexpected results.

Sometimes screen dimensions are needed in code, so to make them more generic I propose adding generic/screen.h which would contain defines with PAL/NTSC screen boundaries, also hires/laced variants. Also, PAL/NTSC names will be more meaningful
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tehKaiN