Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game manager tweaks #33

Closed
tehKaiN opened this issue Dec 18, 2017 · 1 comment · Fixed by #122
Closed

Game manager tweaks #33

tehKaiN opened this issue Dec 18, 2017 · 1 comment · Fixed by #122
Assignees
Labels
Easy Good starting point if you want to help enhancement question

Comments

@tehKaiN
Copy link
Member

tehKaiN commented Dec 18, 2017

  1. Remove pView field and viewLoad() stuff
    1. This code doesn't work anyway since gamestate struct's view is set to 0
    2. There may be gamestates which don't have their own view - such as pause menu displayed in border on game's main vport.
  2. gameDestroy() should call gamePopState() in a loop
    1. Less code to maintain
    2. Speed isn't crucial during gameDestroy()
  3. Remove fadeout remnants from code
    1. This should be shifted to gamestate implementation or viewport managers since in multi-viewport view with color-changing copperlist doing palette fade isn't trivial task.

Since @approxit is responsible for game manager, I'd like to see his opinion in the comments.

@tehKaiN tehKaiN added the Easy Good starting point if you want to help label Apr 28, 2018
@tehKaiN
Copy link
Member Author

tehKaiN commented May 5, 2018

@approxit ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Good starting point if you want to help enhancement question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants