Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestfulZoldNet.java:38-39: Add methods for API entry... #11

Closed
0pdd opened this issue Jan 15, 2019 · 13 comments
Closed

RestfulZoldNet.java:38-39: Add methods for API entry... #11

0pdd opened this issue Jan 15, 2019 · 13 comments
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link

0pdd commented Jan 15, 2019

The puzzle 4-040a72fe from #4 has to be resolved:

* @todo #4:30min Add methods for API entry points to this class, once we find
* the actual API docs for Zold.

The puzzle was created by @amihaiemil on 15-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Author

0pdd commented Jan 15, 2019

@amihaiemil please pay attention to this new issue.

@0pdd 0pdd added bug Something isn't working pdd labels Jan 15, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 15, 2019

@amihaiemil/z please, pay attention to this issue

@amihaiemil
Copy link
Owner

We should follow the example of zold-ruby-sdk -- start with a method from there :)

@0crat 0crat added the scope label Jan 15, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 15, 2019

Job #11 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jan 15, 2019

The job #11 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@ammaratef45
Copy link
Collaborator

@amihaiemil
One of the methods I was adding is
void pay(String keygap, String user, double amount, String details);
But it has more than 3 parameters
I get that error

[ERROR] More than 3 parameters (found 4). [ParameterNumber]

what should I do? I was thinking of creating a class called payment that holds the recipient, amount and details

@ammaratef45
Copy link
Collaborator

@0crat wait
waiting for a decision

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

@0crat wait waiting for a decision (here)

@ammaratef45 The impediment for #11 was registered successfully by @ammaratef45/z

@amihaiemil
Copy link
Owner

@ammaratef45 regarding number of parameters, I would simply escape the Checkstyle rule. However, method pay(...) should be on the Wallet interface. See #16.

Make a PR in which you introduce that interface, with the method :)
Escape checkstyle using the @checkstyle annotation.

@ammaratef45
Copy link
Collaborator

@amihaiemil yes I'm already making it in the interface

@amihaiemil amihaiemil mentioned this issue Jan 20, 2019
amihaiemil added a commit that referenced this issue Jan 20, 2019
@0pdd
Copy link
Author

0pdd commented Jan 20, 2019

The puzzle 4-040a72fe has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

The job #11 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Order was finished: +30 point(s) just awarded to @ammaratef45/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

No branches or pull requests

4 participants