Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for #11 #18

Merged
merged 5 commits into from Jan 20, 2019
Merged

PR for #11 #18

merged 5 commits into from Jan 20, 2019

Conversation

ammaratef45
Copy link
Collaborator

@ammaratef45 ammaratef45 commented Jan 20, 2019 •
edited

Adding methods for ZoldWts interface, solving what is needed issues #4 and #11

Details:
Adding pull, find, balance and pay methods
Adding Wallet interface

@0crat 0crat added the scope label Jan 20, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Job #18 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

This pull request #18 is assigned to @g4s8/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

amihaiemil
amihaiemil reviewed Jan 20, 2019
View reviewed changes
Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ammaratef45 see comments :)

and please give descrptions to your PR's, including a link to the Issue you are fixing. For instnace, this PR is for issue #11, not #4.

src/main/java/com/amihaiemil/zold/RestfulZoldWts.java Outdated Show resolved Hide resolved
src/main/java/com/amihaiemil/zold/RestfulZoldWts.java Show resolved Hide resolved
@ammaratef45 ammaratef45 changed the title PR for #4 PR for #11 Jan 20, 2019
amihaiemil
amihaiemil reviewed Jan 20, 2019
View reviewed changes
Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ammaratef45 better, but still not complete :D

src/main/java/com/amihaiemil/zold/ZoldWts.java Outdated Show resolved Hide resolved
src/main/java/com/amihaiemil/zold/RestfulZoldWts.java Show resolved Hide resolved
src/main/java/com/amihaiemil/zold/Wallet.java Outdated Show resolved Hide resolved
@amihaiemil amihaiemil merged commit 10d890e into amihaiemil:master Jan 20, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Job was finished in 1 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Quality is low, no payment, see §31:

@0crat 0crat removed the scope label Jan 20, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

The job #18 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amihaiemil amihaiemil amihaiemil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ammaratef45 @0crat @amihaiemil