Use BigDecimal instead of double

[denis-konovalyenko]

There are 2 methods of the Wallet interface, which uses double type: balance and pay.

Representing money as a double or float will probably look good at first as the software rounds off the tiny errors, but as you perform more additions, subtractions, multiplications and divisions on inexact numbers, errors will compound and you'll end up with values that are visibly not accurate. This makes floats and doubles inadequate for dealing with money, where perfect accuracy for multiples of base 10 powers is required.

A solution that works in just about any language is to use integers instead, and count cents. For instance, 1025 would be $10.25. Several languages also have built-in types to deal with money. Among others, Java has the BigDecimal class, and C# has the decimal type.

For more details please refer to this resource.

[0crat]

@amihaiemil/z please, pay attention to this issue

[denis-konovalyenko]

@amihaiemil , as an alternative, I am tending to like this more and more, we can easily go with String types for balance and pay methods and leave all type conversion/parsing for the upper/user layer:

    String balance();
    void pay(
        final String keygap, final String user,
        final String amount, final String details
    );

What do you think?

[amihaiemil]

@denis-konovalyenko looks good! We do it with Strings and let folks take care of it, it's safer :)

[0crat]

Job #44 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 point(s) just awarded to @denis-konovalyenko/z

[0crat]

The job #44 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

[ammaratef45]

@denis-konovalyenko Is it fine now?

[denis-konovalyenko]

@ammaratef45 , what do you mean? As far as the pull request has been merged, 0crat should put the issue out of scope and close it. Maybe, it is too lazy today and it will take it a bit of time to accomplish that. :)

[ammaratef45]

@denis-konovalyenko Hmmm, usually zerocrat doesn't close issues (reporter close it or PDD if it was a puzzle)
Am I missing something?

[denis-konovalyenko]

@amihaiemil , ah, no problem. I think this is not clearly stated in the policy (or I missed that).

[0crat]

Job was finished in 31 hours, bonus for fast delivery is possible (see §36)

[0crat]

The job #44 is now out of scope

[0crat]

Order was finished: +35 point(s) just awarded to @ammaratef45/z