Double to string for #44

[ammaratef45]

PR for #44
Changed double to string when referring to balance.

[0crat]

Job #45 is now in scope, role is REV

[0crat]

This pull request #45 is assigned to @g4s8/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[g4s8]

@ammaratef45 please see few comments

[g4s8]

@ammaratef45 this change will affect JSON payload format, type amount changed from JSON-number to JSON-string:
before:

{
  "amount": 1234.56
}

after:

{
  "amount": "1234.56"
}

I'm not sure here (because I didn't find API docs for JSON payload), but most probably API won't accept such format.

[ammaratef45]

@g4s8 reverting it makes the issue meaningless, what do you think? we may need to rediscuss the issue, right?

[g4s8]

@ammaratef45 you can use json.add("amount", new BigDecimal(amount)) - that code adds amount as json number, but with arbitrary precision

[ammaratef45]

@g4s8 The problem is that this change meant to be used for avoiding any casting or precision problems and let the higher layers handle this.

[g4s8]

@ammaratef45 but BigDecimal doesn't limit the precision, so I think it's safe to use here. In any case we should conform to wts API protocol, so if you have any doubts you can submit a ticket to wts repo, e.g. to expand documentation for JSON apis.
// cc @amihaiemil

[denis-konovalyenko]

@ammaratef45 , @g4s8 , @amihaiemil , the following conversion is performed in wts.rb here:

  amount = Zold::Amount.new(zld: params[:amount].to_f)

I am not a Ruby expert but my guess, which is based on the documentation:

"123.45e1".to_f        #=> 1234.5
"45.67 degrees".to_f   #=> 45.67
"thx1138".to_f         #=> 0.0

is that

"amount": "1234.56"

would be interpretted as 1234.56 (Float).

Hope, that would help us out here. By the way, there has been opened a related to accurate decimal operations issue #718 in Zold project.

[ammaratef45]

@g4s8 I've merged the master and the irrelevant changes went away
Also, according to @denis-konovalyenko comment, looks like the string payload of amount won't make a problem (or we need to wait for zold-io/zold#718 )
What do you think?

[g4s8]

@ammaratef45 thanks

[g4s8]

@rultor merge

[rultor]

@rultor merge

@g4s8 Thanks for your request. @amihaiemil Please confirm this.

[amihaiemil]

@rultor merge it

[rultor]

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

[0crat]

Job was finished in 24 hours, bonus for fast delivery is possible (see §36)

[0crat]

The job #45 is now out of scope

[0crat]

Order was finished: +20 point(s) just awarded to @g4s8/z

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z