For #39: Handling InterruptedException properly #42
Conversation
|
@paulodamaso/z this pull request is too small, just 7 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @amihaiemil/z please review this and merge or reject |
| throw new IllegalStateException( | ||
| "Exception while waiting for Wallet!", ex | ||
| ); | ||
| } catch (final InterruptedException iex) { | ||
| Thread.currentThread().interrupt(); |
There was a problem hiding this comment.
@paulodamaso after interrupting the Thread, shouldn't we throw IllegalStateException as well? :D
There was a problem hiding this comment.
@amihaiemil According to the ticket description and the documentation provided we must choose between one of two: either rethrow the exception or interrupt the thread
|
@amihaiemil Answered, please take a look |
|
@paulodamaso right, I forgot, sorry :) |
|
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
|
Job |
|
This job is not in scope |
For #39: Handling
InterruptedExceptionproperlyThread.currentThread().interrupt();onInterruptedException