New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect interruption handling #39
Comments
@amihaiemil/z please, pay attention to this issue |
Job #39 is now in scope, role is |
@paulodamaso/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
@amihaiemil So, which option I implement:
|
@0crat wait for answer of question in comment #39 (comment) |
@paulodamaso The impediment for #39 was registered successfully by @paulodamaso/z |
@amihaiemil ping |
@paulodamaso I would go with option 2: set interrupted flag and cancel running operation |
@g4s8 Merged, please close |
@paulodamaso thanks |
The job #39 is now out of scope |
Order was finished: +30 point(s) just awarded to @paulodamaso/z |
There is a
catch
block inWaitForWallet
:zold-java-client/src/main/java/com/amihaiemil/zold/WaitForWallet.java
Lines 103 to 107 in 721134a
it handles
InterruptedException
but doesn't set interrupted flag of the thread and doesn't terminate the job. It's not correct usage of this kind of exception. It should either addInterruptedException
to method signature and do not handle it; or set interrupted flag and cancel running operation.see https://stackoverflow.com/q/3976344/1723695
The text was updated successfully, but these errors were encountered: