Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interruption handling #39

Closed
g4s8 opened this issue Jan 27, 2019 · 14 comments
Closed

Incorrect interruption handling #39

g4s8 opened this issue Jan 27, 2019 · 14 comments
Labels
bug Something isn't working

Comments

@g4s8
Copy link

g4s8 commented Jan 27, 2019

There is a catch block in WaitForWallet:

} catch (final InterruptedException | URISyntaxException ex) {
throw new IllegalStateException(
"Exception while waiting for Wallet!", ex
);
}

it handles InterruptedException but doesn't set interrupted flag of the thread and doesn't terminate the job. It's not correct usage of this kind of exception. It should either add InterruptedException to method signature and do not handle it; or set interrupted flag and cancel running operation.
see https://stackoverflow.com/q/3976344/1723695

@0crat
Copy link
Collaborator

0crat commented Jan 27, 2019

@amihaiemil/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2019

Job #39 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2019

Bug was reported, see §29: +15 point(s) just awarded to @g4s8/z

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2019

The job #39 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Feb 3, 2019

@paulodamaso/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@paulodamaso
Copy link
Contributor

@amihaiemil So, which option I implement:

  1. add InterruptedException to method signature and do not handle it; OR
  2. set interrupted flag and cancel running operation?

@paulodamaso
Copy link
Contributor

@0crat wait for answer of question in comment #39 (comment)

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2019

@0crat wait for answer of question in comment https://github.com/amihaiemil/zold-java-client/issu... (here)

@paulodamaso The impediment for #39 was registered successfully by @paulodamaso/z

@paulodamaso
Copy link
Contributor

@amihaiemil ping

@amihaiemil
Copy link
Owner

amihaiemil commented Feb 9, 2019

@paulodamaso I would go with option 2: set interrupted flag and cancel running operation

@paulodamaso
Copy link
Contributor

@g4s8 Merged, please close

@g4s8
Copy link
Author

g4s8 commented Feb 12, 2019

@paulodamaso thanks

@g4s8 g4s8 closed this as completed Feb 12, 2019
@0crat 0crat removed the scope label Feb 12, 2019
@0crat
Copy link
Collaborator

0crat commented Feb 12, 2019

The job #39 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Feb 12, 2019

Order was finished: +30 point(s) just awarded to @paulodamaso/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants