Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ratio parameter to adjust adsr and sleep #14

Closed
amiika opened this issue Feb 7, 2019 · 3 comments
Closed

Add ratio parameter to adjust adsr and sleep #14

amiika opened this issue Feb 7, 2019 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@amiika
Copy link
Owner

amiika commented Feb 7, 2019

Use default synth release by default. Add ratio parameter for adjusting release and sleep.

Could also add some swing paramater that would variate that ratio on the fly.
@amiika amiika changed the title Use default synth release and add additional ratio parameter for adjusting sleep and release Add ratio parameter to adjust adsr and sleep Sep 29, 2019
@amiika
Copy link
Owner Author

amiika commented Sep 29, 2019

Refactored sleep vs. adsr but it still could be better

@amiika amiika added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 4, 2019
@amiika
Copy link
Owner Author

amiika commented Oct 4, 2019

ADSR is not set using this formula: 1.5 * sleep * adsr.

For example: 1.5 * 0.5(sleep) * 1(release)

See set_ADSR

How it should be done?

@amiika amiika added the question Further information is requested label Oct 4, 2019
@amiika
Copy link
Owner Author

amiika commented Nov 19, 2021

This was deprecated in Ziffers 2 ... need to think this again.

@amiika amiika closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amiika