Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin not working if current page has git submodule #26

Closed
publicqi opened this issue Jan 4, 2024 · 2 comments · Fixed by #27
Closed

Plugin not working if current page has git submodule #26

publicqi opened this issue Jan 4, 2024 · 2 comments · Fixed by #27
Labels
bug Something isn't working

Comments

@publicqi
Copy link
Contributor

publicqi commented Jan 4, 2024

Describe the bug
The plugin is not rendering the size tab nor the size of other files when there's a submodule in page. I did not test if this also exists in sub folders of a repo, but it does not show size in the main page.

To Reproduce

  1. Goto https://github.com/frida/frida/
  2. The size is not showing

Expected behavior
I guess it should just ignore the submodule size?

Screenshots

Platform:

Additional context

@AminoffZ
Copy link
Owner

AminoffZ commented Jan 4, 2024

Thanks for pointing this out. This was partly noted in #9 but due to the recent update, it's gotten more critical.

@AminoffZ AminoffZ added the bug Something isn't working label Jan 4, 2024
@mAmineChniti
Copy link
Collaborator

Thank you for letting us know, this is a duplicate issue we have already flagged this #9 and will be working on it, if you'd be so kind as to close down this issue, if you're interested in fixing it on your own https://github.com/AminoffZ/github-repo-size/blob/main/CONTRIBUTING.md we're accepting PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants