Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes in Content Processes starting in Firefox 111 #66

Closed
tomrittervg opened this issue Feb 8, 2023 · 3 comments
Closed

Crashes in Content Processes starting in Firefox 111 #66

tomrittervg opened this issue Feb 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tomrittervg
Copy link

Users of Nightly 111 may have started experiencing content process crashes in the past 2 days. Once 111 goes to Beta/Release, users on Beta or Release may start experiencing incorrect behavior.

This is because I landed 1811294 which will cause content process crashes when dynamically named string preferences (i.e. preferences that aren't specified in prefs.js or StaticPrefList) are accessed in the content process. I'm here because we just got crash reports for one user accessing userChrome.searchSelectionShortcut.keycode which I know is a userchrome thing.

There are preferences that affect the crashing behavior referenced in that bug. As before, Mozilla's policy is that userschrome stuff is not supported, so we're not going to go out of our way to make things work* and we don't recommend you disable security settings. But at the same time we appreciate all of our users and as one hacker to another(s) - I wanted to give you a head's up.

* well actually, we've been going really far out of our way for a while, but there are limits

I also left this comment at xiaoxiaoflood/firefox-scripts#241 which is where I frequently post updates for userchrome stuff.

@tomrittervg tomrittervg added the bug Something isn't working label Feb 8, 2023
@aminomancer
Copy link
Owner

Thanks for reporting! I can probably just have these scripts request the pref values from the parent process.

@aminomancer
Copy link
Owner

kinda looks like if I prefixed all the custom prefs with ui., they wouldn't get blocklisted in the first place. curious what you think about that?

@tomrittervg
Copy link
Author

Yeah, either approach would work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants