-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the keyboard to navigate between sliders #112
Comments
Nice feature, currently it can be achieved using widgets api: export default class KeyboardNavigator extends React.Component {
componentDidMount () {
const { index, total, loop, prevHandler, nextHandler } = props
// Add event listener, call prevHandler/nextHandler on keypress
}
componentWillUnmount () {
// Cleanup event listeners.
}
render () { return null }
} |
So we should not work on this, as a feature? |
Since it's not too much burden to achieve (like Buttons, IndicatorDots), I'd like to keep the core feature as simple as possible. Similar use cases may vary, navigation could be caused by keypress, key combination, gesture, maybe more. So I prefer to expose a simple api to support these, other than make them built-in feature. What do you think? |
I agree, but then we should add that in the documention because the accessibility its a important goal |
I would like to work on this new feature.
Increase the accessibility of the carousel.
It would be a new prop
The text was updated successfully, but these errors were encountered: