Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the definition of two constants so that Donut can be checked out outside the Q2A folder #111

Open
bertrandgorge opened this issue Feb 11, 2020 · 0 comments

Comments

@bertrandgorge
Copy link

In case you pull Donut in a separate directory, then build a symbolic link of the plugin and the theme into q2a, two defines would break the code because they would refer to the original checkout dir and not q2a. By using Q2A already defined constants we can work around this issue:

    @define( 'DONUT_THEME_BASE_DIR', dirname( __FILE__ ) );
    @define( 'DONUT_THEME_BASE_DIR', QA_BASE_DIR . 'qa-theme/Donut-theme');
bertrandgorge added a commit to NeayiAbandoned/Donut that referenced this issue Feb 11, 2020
…t outside the Q2A folder

In case you pull Donut in a separate directory, then build a symbolic link of the plugin and the theme into q2a, two defines would break the code because they would refer to the original checkout dir and not q2a. By using Q2A already defined constants we can work around this issue.

Fixes issue amiyasahu#111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant