Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for fat file names #95

Closed
Amjad50 opened this issue Apr 1, 2024 · 0 comments · Fixed by #108
Closed

Improvement for fat file names #95

Amjad50 opened this issue Apr 1, 2024 · 0 comments · Fixed by #108
Assignees
Labels
bug Something isn't working io I/O related work kernel Kernel related work

Comments

@Amjad50
Copy link
Owner

Amjad50 commented Apr 1, 2024

So, there are 2 issues currently relating to fat names

1- we are comparing files incorrectly, FAT by nature is case insensitive, so we need to compare files correctly when treversing. For this, we can have a new method in the Filesystem trait that will allow comparing entries, or maybe another method that will handle treversing?

2- Currently, if there is a file named longfilename1, if we try to create longfilename2, it will tell us the file already exists, I'm not sure if this is correct since the short name will match and become LONGFI~1, if that happened, we need to instead choose another value, it could be from ~1 to ~999999.

@Amjad50 Amjad50 added bug Something isn't working kernel Kernel related work io I/O related work labels Apr 1, 2024
@Amjad50 Amjad50 mentioned this issue Jul 8, 2024
3 tasks
@Amjad50 Amjad50 self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working io I/O related work kernel Kernel related work
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant