Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataloader.py line 67 #3

Closed
connorchen opened this issue Jul 16, 2018 · 1 comment
Closed

dataloader.py line 67 #3

connorchen opened this issue Jul 16, 2018 · 1 comment

Comments

@connorchen
Copy link

Hi,
labels_in_bag = labels_in_bag >= self.target_number
i think the purpose of the code is if the target exists in the labels_in_bag, so '>=' should be '=='
If my understanding is wrong, please correct me.
Thanks

@max-ilse
Copy link
Collaborator

Hi connorchen,
You are right. I just fixed that bug. Since we were using '9' as the target number that bug never caused issues. Thanks for pointing it out.
Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants