Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests and integration tests for the candidate network edge set of a given graph #105

Closed
recursion-ninja opened this issue Dec 14, 2018 · 5 comments

Comments

@recursion-ninja
Copy link
Collaborator

We need a lot more tests for this!

@recursion-ninja
Copy link
Collaborator Author

Property, if we have a valid network N0 and another valid network N1 then the graph:

   r
 /   \
N0    N1

should have a number of candidate network edges equal to the product of the number of candidate network edges in N0 and the number of candidate network edges of N1 minus the number of network edges.

We can start testing this property with binary trees and explore simple network constructions to arbitrarily generate.

@recursion-ninja
Copy link
Collaborator Author

recursion-ninja commented Jan 7, 2019

Property, if we have a valid network N0, N1, N2, and N3 then the graph:

      r
   /     \
 N0       a
         / \
       b     c
     /  \  /  \
    N1   d     N3
         |
        N2

There should be no candidate network edges between (a,b), (a,c), and any edges from N1, N2, or N3.

@recursion-ninja
Copy link
Collaborator Author

Property, if we have a valid networks N0, N1, and N2; then the graph:

      r
    /   \
  N0     x
        / \
       N1  N2

should not have any network edges from (r,x), (x,N1), (x, N2). and any edges in N1 or N2.

@Boarders
Copy link
Collaborator

This is now (hopefully!) complete as of this commit: 2ed85b4

@recursion-ninja
Copy link
Collaborator Author

This looks absolutely great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants