Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dynamic character analysis is broken for the L1-norm (additive) #78

Closed
recursion-ninja opened this issue Oct 5, 2018 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@recursion-ninja
Copy link
Collaborator

When a dynamic character is input that uses the L1 norm (additive) metric, runtime exceptions are thrown regarding the specialized handling of this metric. I assume that the error exists in the Ranged instance definition of the DynamicCharacterElement. We need to correct the instance definition (or the calling code) so that this is handled appropriately.

@recursion-ninja
Copy link
Collaborator Author

recursion-ninja commented Oct 18, 2018

There appears to be a defect in the decoding from the alphabet.

Alphabets = [ "A", "B", "C" ]

and there exists something like this in the parse result:"AB":[]

We get the empty bitvector when decoding this because notElem "AB" [ "A", "B", "C" ].

@Boarders
Copy link
Collaborator

Boarders commented Oct 18, 2018

The example in the integration test fails as the read grammar is not specific enough to be able to specify reading the file as a particular alphabet, e.g. protein, instead of as a custom alphabet. The same problem appears in the Sankoff example here #80.

@recursion-ninja
Copy link
Collaborator Author

recursion-ninja commented Oct 30, 2018

I corrected a defect in the bit-vector arithmetic used when converting between characters and ranges.

See commit 5e4401e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants