Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 2.7 breaks cli #131

Closed
arahansen opened this issue Feb 1, 2018 · 4 comments · Fixed by #132
Closed

TypeScript 2.7 breaks cli #131

arahansen opened this issue Feb 1, 2018 · 4 comments · Fixed by #132

Comments

@arahansen
Copy link

arahansen commented Feb 1, 2018

the typescriptPrettify module depends on the typescript.formatter.RulesProvider it seems this was removed in a recent release of TypeScript.

Since the CLI pulls this module in, I'm not able to use it on gql2ts@1.4.0

language-typescript declares its typescript depdency as ^2.2.2 which means it will automatically install 2.7.

I think the version needs to be locked to 2.2.2 (ie, no ^ in the dependency), or the prettifier should be updated to 2.7.

Alternatively, lock typescript to the last working version which seems to be 2.6

@arahansen arahansen changed the title TypeScript 2.7 breaks typescriptPrettify TypeScript 2.7 breaks cli Feb 1, 2018
@brettjurgens
Copy link
Contributor

brettjurgens commented Feb 2, 2018

that's not good, i'll lock the version down in the meantime while figuring out the path forward

@brettjurgens
Copy link
Contributor

@arahansen i've just published version 1.4.1. would you mind trying and seeing if it fixes this issue?

@brettjurgens
Copy link
Contributor

opened #133 to further the discussion about how to proceed

@arahansen
Copy link
Author

Changes look good on 1.4.1. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants