Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make apache vhost config 12 factor friendly #52

Closed
michaelmcandrew opened this issue Mar 2, 2018 · 2 comments
Closed

Make apache vhost config 12 factor friendly #52

michaelmcandrew opened this issue Mar 2, 2018 · 2 comments

Comments

@michaelmcandrew
Copy link
Contributor

Hey there,

https://12factor.net/logs stats that you should treat logs as streams.

In the Docker apache image this is achieved by symlinking the apache log files to /dev/stderr and /dev/stdout` see this comment for more details.

By default amp defines its own log files for each site, which overrides the Docker config.

I know that amp isn't primarily aimed at Docker, and that https://12factor.net/logs is not the final word on app design, but I wanted to draw your attention to this in case you had any thoughts / it was helpful in thinking about how amp is designed.

It's not a blocker and I have got round it in the CiviCRM Docker image with a custom apache vhost template michaelmcandrew/civicrm-buildkit-docker@65a0971 (pending this PR).

@totten
Copy link
Collaborator

totten commented Mar 6, 2018

@michaelmcandrew I've merged the change to have buildkit download amp v0.4.4.

I think it's pretty reasonable for civicrm-buildkit-docker to have a few small differences in how it generates vhost templates (compared to stock/local amp), so overriding apache24-vhost.php makes sense.

@totten totten closed this as completed Mar 6, 2018
@michaelmcandrew
Copy link
Contributor Author

Cool. Sounds good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants