Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled promises #61

Closed
kelunik opened this issue Jan 8, 2017 · 3 comments
Closed

Unhandled promises #61

kelunik opened this issue Jan 8, 2017 · 3 comments

Comments

@kelunik
Copy link
Member

kelunik commented Jan 8, 2017

https://github.com/cujojs/when/blob/master/docs/api.md#edge-cases

Maybe we want to introduce something similar when assertions are enabled logging warnings.

@bwoebi
Copy link
Member

bwoebi commented Jan 9, 2017

I cannot really imagine how this will work without a ton of false positives…

@kelunik
Copy link
Member Author

kelunik commented Feb 24, 2017

@bwoebi We could trigger a warning in case a promise is destructed without a single handler being called. Every promise should at least have a rethrow handler somewhere.

@kelunik
Copy link
Member Author

kelunik commented Mar 12, 2017

It will indeed result in a lot of false positives in case of non-consumed bodies in Aerys, etc.

@kelunik kelunik closed this as completed Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants