Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for \Amp\Struct #110

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Add doc for \Amp\Struct #110

merged 1 commit into from
Mar 19, 2017

Conversation

aenglander
Copy link

No description provided.

kelunik
kelunik reviewed Mar 19, 2017
View reviewed changes
Copy link
Member

@kelunik kelunik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example can be shortened, but otherwise LGTM. 👍

docs/structs.md

$clazzy = new $clazz();
$clazzy->fooo = "bar";
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example could just be that:

$obj = new class {
    public $foo = null;
};

$obj->fooo = "bar";

See https://3v4l.org/opivb.

@kelunik kelunik merged commit d23a7db into amphp:master Mar 19, 2017
@kelunik
Copy link
Member

kelunik commented Mar 19, 2017

I just did the proposed changes myself. Thanks for providing the PR!

@kelunik kelunik mentioned this pull request Mar 20, 2017
Closed
staabm pushed a commit to staabm/amp that referenced this pull request Nov 29, 2017
@bwoebi
Merge pull request amphp#110 from async-interop/issue-95
11c04e9 
Define error handler behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aenglander @kelunik