-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make drivers more consistent / reduce driver API #38
Conversation
bb3ad96
to
6b30218
Compare
ping @kelunik |
1880cf0
to
5570fd4
Compare
@kelunik Most likely chown needs the same treatment with |
@enumag The test won't work that way due to umask. |
@kelunik Is there a way to fix it or do I have to remove it? |
@enumag I guess |
790d526
to
ed5ccf3
Compare
@kelunik Actually |
1a0bcf4
to
1a7f4c0
Compare
1310ea4
to
9fdedb6
Compare
Co-authored-by: Niklas Keller <me@kelunik.com>
86b2aab
to
b0105ce
Compare
Co-authored-by: Niklas Keller <me@kelunik.com>
Co-authored-by: Niklas Keller <me@kelunik.com>
@bwoebi Could you take a look what's wrong with |
@enumag Yes, we should indeed finally tag v2. I guess the code is ready, we just need to write a changelog. I originally wanted to wrap |
@kelunik Well the notable changes are these:
Then it depends on if you want to
|
That's a good starting point, yes. I think listing the renames makes senses, as it only needs to be done once, otherwise everybody will have to spend time looking things up. I'm not sure whether detailed changelogs for the driver interface makes sense, as there probably aren't many people who implemented their own driver. Do you want to work on that? |
@kelunik here is what I gathered: Renamed: Added: Changed: |
ping @kelunik Anything else I can help with here? |
No, thank you! I'll get it tagged in the coming days. Sorry about the delay. |
I finally got to my notebook and tagged the release, thank you so much! |
Thanks @kelunik! I noticed a few things when browsing the latest commits.
I'll try to find some time to update amphp/cache and amphp/http-client. |
I'm using the current master branch of ext-uv, yes. I'm not sure what changes from the last release there. I'm ignoring eio, because the setup-php script doesn't install it currently. If you have a fix for that, please send a PR. |
No description provided.