Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with dg/bypass-finals #67

Closed
ostrolucky opened this issue Jun 7, 2023 · 1 comment
Closed

Doesn't work with dg/bypass-finals #67

ostrolucky opened this issue Jun 7, 2023 · 1 comment

Comments

@ostrolucky
Copy link

Create this bootstrap code and use it in phpunit, then rerun the tests in this project:

<?php

declare(strict_types=1);

require_once __DIR__ . '/../vendor/autoload.php';

\DG\BypassFinals::enable();

This results in

EEEEEEEEEEE.EEEEEEEEEEEEEEEEEEEEEEEESFE                           39 / 39 (100%)

Time: 00:00.036, Memory: 10.00 MB

There were 36 errors:

1) Amp\Process\Test\ProcessTest::testIsRunning
Amp\Process\ProcessException: Process could not be started: Errno: 2; fseek(): Stream does not support seeking
...

In case there isn't anything that can be done about the compatibility, can you at least throw the useful message when its presence is detected? Because finding the culprit isn't easy in large project.

@kelunik
Copy link
Member

kelunik commented Jun 7, 2023

I'm not willing to spend time on something that interferes in such a way with packages. I think this should be reported to that library instead. It obviously does more than bypassing final then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants